Bug 45968 - [CHROMIUM] GPU-accelerated canvas should work in test_shell.
Summary: [CHROMIUM] GPU-accelerated canvas should work in test_shell.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-17 08:58 PDT by Stephen White
Modified: 2010-09-17 11:02 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.31 KB, patch)
2010-09-17 09:07 PDT, Stephen White 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2010-09-17 08:58:29 PDT 
The shaders for GPU-accelerated canvas should be modified to work in the in-process Mesa backend in test_shell.
Comment 1 Stephen White 2010-09-17 09:07:54 PDT 
Created attachment 67913 [details]
Patch
Comment 2 Kenneth Russell 2010-09-17 09:23:43 PDT 
While I think this might be a good idea in the short term, I'm not sure it's a good idea in the long term. zmo was working on integrating the ANGLE shader translator with the in-process WebGL implementation, which should allow the precision qualifiers to work unmodified.
Comment 3 Stephen White 2010-09-17 09:31:22 PDT 
(In reply to comment #2)
> While I think this might be a good idea in the short term, I'm not sure it's a good idea in the long term. zmo was working on integrating the ANGLE shader translator with the in-process WebGL implementation, which should allow the precision qualifiers to work unmodified.

As I'm sure you know, this technique has been used on a lot of WebGL content to satisfy the recent spec change while still remaining compatible with older browsers.  It should work fine after the translator is implemented, at which point we can remove the #ifdefs at our leisure.

Testing is a pretty high priority IMHO, so could we let this in for now?
Comment 4 Kenneth Russell 2010-09-17 10:10:59 PDT 
Comment on attachment 67913 [details]
Patch

OK.
Comment 5 Stephen White 2010-09-17 11:02:03 PDT 
Committed r67727: <http://trac.webkit.org/changeset/67727>