WK2: REGRESSION (r66156): Web sites using AppleConnect fail to log in: "HTTP Status 404 - /ssowebapp/scriptFrame"

[Andy Estes]

In http://trac.webkit.org/changeset/66437, WebKit was modified to workaround a bug in the AppleConnect plug-in. This workaround needs to be in WebKit2 as well.

[Andy Estes]

<rdar://problem/8440903>

[Andy Estes]

Created attachment 67905 [details]
Patch

[Andy Estes]

Created attachment 67906 [details]
Patch

[Darin Adler]

Comment on attachment 67906 [details]
Patch

>      Plugin::Parameters parameters;
>      parameters.url = url;
> -    parameters.names = paramNames;
>      parameters.values = paramValues;
>      parameters.mimeType = mimeType;
>      parameters.loadManually = loadManually;
> +    
> +    // <rdar://problem/8440903>: AppleConnect has a bug where it does not
> +    // understand the parameter names specified in the <object> element that
> +    // embeds its plug-in. This hack works around the issue by converting the
> +    // parameter names to lowercase before passing them to the plug-in.
> +    if (equalIgnoringCase(mimeType, "application/x-snkp")) {
> +        parameters.names.reserveCapacity(paramNames.size());
> +        for (size_t i = 0; i < paramNames.size(); ++i)
> +            parameters.names.append(paramNames[i].lower());
> +    } else
> +        parameters.names = paramNames;

Why not leave the line of code above alone, and write the new code as a removable block. That seems to isolate the AppleConnect workaround a little better from the non-workaround code.

r=me

[Andy Estes]

Committed r67748: <http://trac.webkit.org/changeset/67748>

[Andy Estes]

Reopening to address additional feedback from Darin.

[Andy Estes]

Filed https://bugs.webkit.org/show_bug.cgi?id=46076 to track adding support for enabling site-specific quirks in WebKit2.

[Andy Estes]

Created attachment 68059 [details]
Patch

[Andy Estes]

Committed r67858: <http://trac.webkit.org/changeset/67858>