Bug 45944 – Update percent-image-height layout test to include additional parent element positioning modes.

• Status: UNCONFIRMED
• Component: New Bugs

[Luke Macpherson]

Update percent-image-height layout test to include additional parent element positioning modes.

[Luke Macpherson]

Created attachment 67879 [details]
Patch

[Luke Macpherson]

Created attachment 67880 [details]
Patch

[Ojan Vafai]

Comment on attachment 67880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67880&action=prettypatch

> LayoutTests/fast/images/percent-height-image.html:34
> +    function runTests() {

Here and below: WebKit style is to put the opening bracket on the next line. Not all the JS code follows the style since there's no formal WebKit JS style, but we're trying to push it in that direction to make it match C++.

> LayoutTests/fast/images/percent-height-image.html:43
> +        document.querySelector("body").className = name;

how about:
document.getElementById('parent').className = name.

Then  you can change the selectors in the CSS above to just have the className. I think that would make the test a bit more readable.

> LayoutTests/fast/images/percent-height-image.html:48
> +            log(className + " FAIL: image height was " + actual + " expected " + expected);

Indentation is off.

> LayoutTests/fast/images/percent-height-image.html:56
> +    Tests that an image with height 100% inside a floated div keeps its intrinsic height.<br/>

This description is no longer accurate.

[James Robinson]

Comment on attachment 67880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67880&action=prettypatch

> LayoutTests/fast/images/percent-height-image.html:39
> +        test("testOne", child, 20);
> +        test("testTwo", child, 20);
> +        test("testThree", child, 20);
> +        test("testFour", child, 20);

I'm pretty sure Firefox returns 0 here, and I'm pretty sure that is the correct answer.