Bug 45932 - Crash due to timer triggered GC occuring while other global data is active
Summary: Crash due to timer triggered GC occuring while other global data is active
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-16 16:09 PDT by Oliver Hunt
Modified: 2010-09-16 18:19 PDT (History)
0 users

See Also:


Attachments
Patch (5.38 KB, patch)
2010-09-16 16:29 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-09-16 16:09:41 PDT
Crash due to timer triggered GC occuring while other global data is active
Comment 1 Oliver Hunt 2010-09-16 16:29:22 PDT
Created attachment 67859 [details]
Patch
Comment 2 Geoffrey Garen 2010-09-16 16:38:23 PDT
Comment on attachment 67859 [details]
Patch

r=me

APIEntryShim is probably a better abstraction to use here.

It's pretty subtle when you should use JSLock vs APIEntryShim. We should work to clear that up in the future.
Comment 3 Oliver Hunt 2010-09-16 18:19:08 PDT
Committed r67683: <http://trac.webkit.org/changeset/67683>