Bug 45923 - [Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
Summary: [Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Performance, Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-09-16 15:28 PDT by Andreas Kling
Modified: 2010-09-17 08:15 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (1.38 KB, patch)
2010-09-16 15:29 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-09-16 15:28:19 PDT 
QPainter::clipPath() can be very expensive, so use QPainter::hasClipping() instead of QPainter::clipPath().isEmpty().
Comment 1 Andreas Kling 2010-09-16 15:29:30 PDT 
Created attachment 67846 [details]
Proposed patch
Comment 2 Ariya Hidayat 2010-09-16 15:31:46 PDT 
Comment on attachment 67846 [details]
Proposed patch

LGTM. re=me.
Comment 3 Andreas Kling 2010-09-16 15:35:37 PDT 
Comment on attachment 67846 [details]
Proposed patch

Clearing flags on attachment: 67846

Committed r67675: <http://trac.webkit.org/changeset/67675>
Comment 4 Andreas Kling 2010-09-16 15:35:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ademar Reis 2010-09-17 08:15:06 PDT 
Revision r67675 cherry-picked into qtwebkit-2.1 with commit 52d2178 <http://gitorious.org/webkit/qtwebkit/commit/52d2178>