Bug 45917 - [GTK] FontPlatformDataFreeType should use smart pointers to hold its members
Summary: [GTK] FontPlatformDataFreeType should use smart pointers to hold its members
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-09-16 14:01 PDT by Martin Robinson
Modified: 2010-09-17 10:42 PDT (History)
1 user (show)

See Also:


Attachments
Patch for this issue (24.27 KB, patch)
2010-09-16 15:32 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-09-16 14:01:48 PDT
Smart pointers will simplify this code greatly and be safer in the long run.
Comment 1 Martin Robinson 2010-09-16 15:32:10 PDT
Created attachment 67848 [details]
Patch for this issue
Comment 2 WebKit Review Bot 2010-09-16 15:33:58 PDT
Attachment 67848 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/graphics/cairo/PlatformRefPtrCairo.h:27:  cairo_scaled_font_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Martin Robinson 2010-09-17 10:42:26 PDT
Comment on attachment 67848 [details]
Patch for this issue

Clearing flags on attachment: 67848

Committed r67724: <http://trac.webkit.org/changeset/67724>
Comment 4 Martin Robinson 2010-09-17 10:42:30 PDT
All reviewed patches have been landed.  Closing bug.