Bug 45907 – convert fast/events/5056619.html to a dump-as-markup test

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

convert fast/events/5056619.html to a dump-as-markup test

[Tony Chang]

Created attachment 67818 [details]
Patch

[Tony Chang]

This test is failing pixel results on Chromium Linux because of anti-aliased fonts.  Rather than check in a new baseline, I'm converting this test to a dump-as-markup test because it's actually testing to see if there's a crash when performing a drag & drop operation.  I use dump-as-markup instead of dump-as-text to verify that the input element is removed from the dom (input elements and their contents don't show up in dump-as-text tests).

[Ryosuke Niwa]

Comment on attachment 67818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67818&action=prettypatch

> LayoutTests/fast/events/5056619.html:5
> +Markup.noAutoDump();

You should probably call waitUntilDone instead.  But do you really need this?

> LayoutTests/fast/events/5056619.html:16
> +    layoutTestController.dumpEditingCallbacks();

Good change.

> LayoutTests/fast/events/5056619.html:43
> +    Markup.dump(document.body, "body after drop");

Consider calling Markup.description(<description>) and just Markup.dump() instead?

[Tony Chang]

Created attachment 67828 [details]
Patch

[Tony Chang]

(In reply to comment #3)
> (From update of attachment 67818 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67818&action=prettypatch
> 
> > LayoutTests/fast/events/5056619.html:5
> > +Markup.noAutoDump();
> 
> You should probably call waitUntilDone instead.  But do you really need this?

Removed

> > LayoutTests/fast/events/5056619.html:43
> > +    Markup.dump(document.body, "body after drop");
> 
> Consider calling Markup.description(<description>) and just Markup.dump() instead?

Switched to using Markup.description.  I prefer dumping document.body to avoid getting everything in <script> in the output.

[Ryosuke Niwa]

Comment on attachment 67828 [details]
Patch

LGTM.  But I'm not a reviewer yet :(

[Tony Chang]

Committed r67678: <http://trac.webkit.org/changeset/67678>