Bug 45897 - Web Inspector: highlight DOM node when hover on link element or DOM breakpoint
Summary: Web Inspector: highlight DOM node when hover on link element or DOM breakpoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-16 09:22 PDT by Pavel Podivilov
Modified: 2010-09-20 04:42 PDT (History)
10 users (show)

See Also:

Attachments
Proposed patch. (11.15 KB, patch)
2010-09-16 09:39 PDT, Pavel Podivilov 		pfeldman: review+
Details | Formatted Diff | Diff
Proposed patch. (12.20 KB, patch)
2010-09-20 03:52 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-09-16 09:22:45 PDT 
Web Inspector: highlight DOM node when hover on link element or DOM breakpoint
Comment 1 Pavel Podivilov 2010-09-16 09:39:37 PDT 
Created attachment 67805 [details]
Proposed patch.
Comment 2 Pavel Feldman 2010-09-17 04:57:31 PDT 
Comment on attachment 67805 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=67805&action=prettypatch

> WebCore/inspector/front-end/BreakpointsSidebarPane.js:188
> +    WebInspector.panels.elements.decorateNodeLabel(WebInspector.domAgent.nodeForId(this._breakpoint.nodeId), link);

please mind nullable nodes.
Comment 3 Pavel Podivilov 2010-09-20 03:52:23 PDT 
Created attachment 68068 [details]
Proposed patch.
Comment 4 WebKit Commit Bot 2010-09-20 04:42:35 PDT 
Comment on attachment 68068 [details]
Proposed patch.

Clearing flags on attachment: 68068

Committed r67844: <http://trac.webkit.org/changeset/67844>
Comment 5 WebKit Commit Bot 2010-09-20 04:42:40 PDT 
All reviewed patches have been landed.  Closing bug.