Bug 45893 – Add the namespace in a friend declaration to get MSVC recognize it properly.

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Satish Sampath]

This is a fix for a build break caused by r67614 in the chromium windows builders (which use VS 2008). Looks like without the proper namespace, the friend declaration was treated as a forward declaration and the build failed with the following error message:

1>JavaScriptCore\wtf/RefCounted.h(139) : error C2248: 'WebCore::FileWriter::~FileWriter' : cannot access private member declared in class 'WebCore::FileWriter'
1>        webcore\fileapi\FileWriter.h(124) : compiler has generated 'WebCore::FileWriter::~FileWriter' here
1>        webcore\fileapi\FileWriter.h(52) : see declaration of 'WebCore::FileWriter'
1>        JavaScriptCore\wtf/RefCounted.h(137) : while compiling class template member function 'void WTF::RefCounted<T>::deref(void)'
1>        with
1>        [
1>            T=WebCore::FileWriter
1>        ]
1>        webcore\fileapi\FileWriter.h(52) : see reference to class template instantiation 'WTF::RefCounted<T>' being compiled
1>        with
1>        [
1>            T=WebCore::FileWriter
1>        ]

[Satish Sampath]

Created attachment 67800 [details]
Patch

[Jeremy Orlow]

Comment on attachment 67800 [details]
Patch

r=me

[Satish Sampath]

Comment on attachment 67800 [details]
Patch

Clearing flags on attachment: 67800

Committed r67622: <http://trac.webkit.org/changeset/67622>