Bug 45893 - Add the namespace in a friend declaration to get MSVC recognize it properly.
Summary: Add the namespace in a friend declaration to get MSVC recognize it properly.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-16 08:26 PDT by Satish Sampath
Modified: 2010-09-16 08:40 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.02 KB, patch)
2010-09-16 08:28 PDT, Satish Sampath 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Satish Sampath 2010-09-16 08:26:07 PDT 
This is a fix for a build break caused by r67614 in the chromium windows builders (which use VS 2008). Looks like without the proper namespace, the friend declaration was treated as a forward declaration and the build failed with the following error message:

1>JavaScriptCore\wtf/RefCounted.h(139) : error C2248: 'WebCore::FileWriter::~FileWriter' : cannot access private member declared in class 'WebCore::FileWriter'
1>        webcore\fileapi\FileWriter.h(124) : compiler has generated 'WebCore::FileWriter::~FileWriter' here
1>        webcore\fileapi\FileWriter.h(52) : see declaration of 'WebCore::FileWriter'
1>        JavaScriptCore\wtf/RefCounted.h(137) : while compiling class template member function 'void WTF::RefCounted<T>::deref(void)'
1>        with
1>        [
1>            T=WebCore::FileWriter
1>        ]
1>        webcore\fileapi\FileWriter.h(52) : see reference to class template instantiation 'WTF::RefCounted<T>' being compiled
1>        with
1>        [
1>            T=WebCore::FileWriter
1>        ]
Comment 1 Satish Sampath 2010-09-16 08:28:24 PDT 
Created attachment 67800 [details]
Patch
Comment 2 Jeremy Orlow 2010-09-16 08:33:01 PDT 
Comment on attachment 67800 [details]
Patch

r=me
Comment 3 Satish Sampath 2010-09-16 08:40:27 PDT 
Comment on attachment 67800 [details]
Patch

Clearing flags on attachment: 67800

Committed r67622: <http://trac.webkit.org/changeset/67622>