Bug 45890 - [v8] Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
Summary: [v8] Web Inspector: [REGRESSION] Scripts disappear from scripts panel after n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-16 07:31 PDT by Yury Semikhatsky
Modified: 2010-09-16 08:38 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.80 KB, patch)
2010-09-16 07:39 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (6.79 KB, patch)
2010-09-16 08:19 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-09-16 07:31:02 PDT 
Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation

What steps will reproduce the problem?
1. Open DevTools
2. Navigate
3. Check scripts drop down on scripts panel
Comment 1 Yury Semikhatsky 2010-09-16 07:39:44 PDT 
Created attachment 67796 [details]
Patch
Comment 2 Pavel Feldman 2010-09-16 07:44:45 PDT 
Comment on attachment 67796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67796&action=prettypatch

> WebKit/chromium/src/WebDevToolsAgentImpl.cpp:267
>          frontendLoaded();

I'd rather create InspectorController::reconnectFrontend that would internally call connectFrontend(),  restoreDebugger() and restoreProfiler(). Latter ones can be private then.
Comment 3 Yury Semikhatsky 2010-09-16 08:19:02 PDT 
Created attachment 67799 [details]
Patch
Comment 4 Yury Semikhatsky 2010-09-16 08:19:37 PDT 
(In reply to comment #2)
> (From update of attachment 67796 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67796&action=prettypatch
> 
> > WebKit/chromium/src/WebDevToolsAgentImpl.cpp:267
> >          frontendLoaded();
> 
> I'd rather create InspectorController::reconnectFrontend that would internally call connectFrontend(),  restoreDebugger() and restoreProfiler(). Latter ones can be private then.

Done.
Comment 5 Yury Semikhatsky 2010-09-16 08:38:38 PDT 
Comment on attachment 67799 [details]
Patch

Clearing flags on attachment: 67799

Committed r67623: <http://trac.webkit.org/changeset/67623>
Comment 6 Yury Semikhatsky 2010-09-16 08:38:49 PDT 
All reviewed patches have been landed.  Closing bug.