Bug 45868 - update-webkit --chromium spitting out a spurious error
Summary: update-webkit --chromium spitting out a spurious error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-15 19:31 PDT by Prasad Tammana
Modified: 2010-09-18 18:21 PDT (History)
3 users (show)

See Also:


Attachments
Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. (687 bytes, patch)
2010-09-15 19:35 PDT, Prasad Tammana
levin: review-
Details | Formatted Diff | Diff
Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. (1.25 KB, patch)
2010-09-17 15:19 PDT, Prasad Tammana
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Prasad Tammana 2010-09-15 19:31:41 PDT
update-webkit --chromium invokes invokes update-webkit-chromium which checks for gclient.  And it does this by looking the value of `gclient --version`.  When gclient is not in the path, it returns an error.  Given that this is not a failure and the script moves on to look for it in other places, this ends up as spurious error in the output that can be misleading.

One fix would be to redirect stderr of the command to "nul" on windows and "/dev/null" on other platforms.
Comment 1 Prasad Tammana 2010-09-15 19:35:27 PDT
Created attachment 67762 [details]
Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms.
Comment 2 David Levin 2010-09-17 14:11:28 PDT
Comment on attachment 67762 [details]
Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms.

This needs a ChangeLog.
Comment 3 David Levin 2010-09-17 14:16:27 PDT
btw, I see other places in perl code using "File::Spec->devnull()" instead of detecting the OS and setting a variable.
Comment 4 Prasad Tammana 2010-09-17 15:19:11 PDT
Created attachment 67959 [details]
Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms.

Added ChangeLog and using commandExists() instead of back tick.
Comment 5 Adam Barth 2010-09-18 18:21:29 PDT
Comment on attachment 67959 [details]
Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms.

Clearing flags on attachment: 67959

Committed r67806: <http://trac.webkit.org/changeset/67806>
Comment 6 Adam Barth 2010-09-18 18:21:34 PDT
All reviewed patches have been landed.  Closing bug.