WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
45867
Style bot complains about cairo forward declaration naming
https://bugs.webkit.org/show_bug.cgi?id=45867
Summary
Style bot complains about cairo forward declaration naming
Martin Robinson
Reported
2010-09-15 19:20:59 PDT
Typical errors take the form: WebCore/platform/DragImage.h:51: cairo_surface_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] We probably just need to add an exclusion for cairo typedefs.
Attachments
Patch for this issue
(2.81 KB, patch)
2010-09-16 16:29 PDT
,
Martin Robinson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Martin Robinson
Comment 1
2010-09-16 16:29:21 PDT
Created
attachment 67858
[details]
Patch for this issue
Martin Robinson
Comment 2
2010-09-17 10:20:21 PDT
Comment on
attachment 67858
[details]
Patch for this issue Clearing flags on attachment: 67858 Committed
r67722
: <
http://trac.webkit.org/changeset/67722
>
Martin Robinson
Comment 3
2010-09-17 10:20:24 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug