Bug 45853 - Add queue start/stop messages
Summary: Add queue start/stop messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-15 16:50 PDT by Eric Seidel (no email)
Modified: 2010-09-15 17:04 PDT (History)
1 user (show)

See Also:


Attachments
Patch (20.34 KB, patch)
2010-09-15 16:51 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-09-15 16:50:26 PDT
Add queue start/stop messages
Comment 1 Eric Seidel (no email) 2010-09-15 16:51:47 PDT
Created attachment 67742 [details]
Patch
Comment 2 Adam Barth 2010-09-15 16:57:24 PDT
Comment on attachment 67742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67742&action=prettypatch

> WebKitTools/Scripts/webkitpy/tool/bot/queueengine.py:-36
> -from webkitpy.common.net.statusserver import StatusServer

Nice.

> WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py:177
> +    def test_terminating_error(self):
> +        self._test_terminating_queue(KeyboardInterrupt(), "User terminated queue.")
> +        self._test_terminating_queue(TerminateQueue(), "TerminateQueue exception received.")

These could be separate tests.
Comment 3 Eric Seidel (no email) 2010-09-15 17:04:24 PDT
Comment on attachment 67742 [details]
Patch

Clearing flags on attachment: 67742

Committed r67582: <http://trac.webkit.org/changeset/67582>
Comment 4 Eric Seidel (no email) 2010-09-15 17:04:29 PDT
All reviewed patches have been landed.  Closing bug.