RESOLVED FIXED Bug 45853
Add queue start/stop messages
https://bugs.webkit.org/show_bug.cgi?id=45853
Summary Add queue start/stop messages
Eric Seidel (no email)
Reported 2010-09-15 16:50:26 PDT
Add queue start/stop messages
Attachments
Patch (20.34 KB, patch)
2010-09-15 16:51 PDT, Eric Seidel (no email)
no flags
Eric Seidel (no email)
Comment 1 2010-09-15 16:51:47 PDT
Adam Barth
Comment 2 2010-09-15 16:57:24 PDT
Comment on attachment 67742 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67742&action=prettypatch > WebKitTools/Scripts/webkitpy/tool/bot/queueengine.py:-36 > -from webkitpy.common.net.statusserver import StatusServer Nice. > WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py:177 > + def test_terminating_error(self): > + self._test_terminating_queue(KeyboardInterrupt(), "User terminated queue.") > + self._test_terminating_queue(TerminateQueue(), "TerminateQueue exception received.") These could be separate tests.
Eric Seidel (no email)
Comment 3 2010-09-15 17:04:24 PDT
Comment on attachment 67742 [details] Patch Clearing flags on attachment: 67742 Committed r67582: <http://trac.webkit.org/changeset/67582>
Eric Seidel (no email)
Comment 4 2010-09-15 17:04:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.