Bug 45844 – Fix linking issues with windows versions of the gtk+ port

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Fridrich Strba]

The gtk+ port needs some additional windows libraries to link with when building for windows. It also needs to specify $(EXEEXT) for some tools in makefiles because a raw copy is done in one rule. One more symbol must be also exported from the libwebkitgtk dll.

[Fridrich Strba]

Created attachment 67739 [details]
Patch

[Martin Robinson]

Comment on attachment 67739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67739&action=prettypatch

> GNUmakefile.am:251
> +	$(OLE32_LIBS)
Do you think you can put these flags behind a if TARGET_WIN32, just so Unixy people don't get confused about them? :)

[Fridrich Strba]

(In reply to comment #2)
> (From update of attachment 67739 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67739&action=prettypatch
> 
> > GNUmakefile.am:251
> > +	$(OLE32_LIBS)
> Do you think you can put these flags behind a if TARGET_WIN32, just so Unixy people don't get confused about them? :)

Those flags are set to empty by configure for non-windows platforms and to the appropriate libraries on other platforms. Having an additional if - endif forest is thus not necessary

[Martin Robinson]

Comment on attachment 67739 [details]
Patch

Okay.

[WebKit Commit Bot]

Comment on attachment 67739 [details]
Patch

Clearing flags on attachment: 67739

Committed r67963: <http://trac.webkit.org/changeset/67963>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.