Bug 45829 - [Chromium] Change WebHTTPBody::appendFileRange() to take a modification time instead of a WebFileInfo instance
Summary: [Chromium] Change WebHTTPBody::appendFileRange() to take a modification time ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-15 13:24 PDT by Dumitru Daniliuc
Modified: 2010-09-30 13:02 PDT (History)
3 users (show)

See Also:

Attachments
patch #1: overload WebHTTPBody::appendFileRange() (3.65 KB, patch)
2010-09-15 14:23 PDT, Dumitru Daniliuc 		dumi: commit-queue-
Details | Formatted Diff | Diff
patch #1: overload WebHTTPBody::appendFileRange() (4.04 KB, patch)
2010-09-15 21:03 PDT, Dumitru Daniliuc 		fishd: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
patch #2: remove WebHTTPBody::appendFileRange(..., const WebFileInfo&) (3.49 KB, patch)
2010-09-15 22:53 PDT, Dumitru Daniliuc 		no flags Details | Formatted Diff | Diff
patch #2: remove WebHTTPBody::appendFileRange(..., const WebFileInfo&) (3.49 KB, patch)
2010-09-16 22:29 PDT, Dumitru Daniliuc 		fishd: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2010-09-15 13:24:13 PDT 
More data will be added to WebFileInfo (such as last access time, file size, etc.), which is not needed by WebHTTPBody::appendFileRange(), because that method only needs to know the last time a file was modified. We should change it to take a 'double modificationTime' argument directly, instead of taking a WebFileInfo instance.
Comment 1 Dumitru Daniliuc 2010-09-15 14:23:11 PDT 
Created attachment 67714 [details]
patch #1: overload WebHTTPBody::appendFileRange()
Comment 2 WebKit Review Bot 2010-09-15 14:24:55 PDT 
Attachment 67714 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebHTTPBody.cpp:137:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dumitru Daniliuc 2010-09-15 21:03:18 PDT 
Created attachment 67767 [details]
patch #1: overload WebHTTPBody::appendFileRange()

Fixed the style error.
Comment 4 Dumitru Daniliuc 2010-09-15 22:47:50 PDT 
patch #1 landed: r67598.
Comment 5 Dumitru Daniliuc 2010-09-15 22:53:25 PDT 
Created attachment 67773 [details]
patch #2: remove WebHTTPBody::appendFileRange(..., const WebFileInfo&)
Comment 6 WebKit Review Bot 2010-09-15 23:06:30 PDT 
Attachment 67773 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4026026
Comment 7 Dumitru Daniliuc 2010-09-15 23:09:59 PDT 
(In reply to comment #6)
> Attachment 67773 [details] did not build on chromium:
> Build output: http://queues.webkit.org/results/4026026

this is expected. the patch won't build until http://codereview.chromium.org/3405010 is submitted.
Comment 8 Dumitru Daniliuc 2010-09-16 21:59:46 PDT 
patch #2 landed: r67693.
Comment 9 Dumitru Daniliuc 2010-09-16 22:28:38 PDT 
Need to wait on WebKit to pick up a newer Chromium version that includes r59767 before re-landing patch #2...
Comment 10 Dumitru Daniliuc 2010-09-16 22:29:56 PDT 
Created attachment 67885 [details]
patch #2: remove WebHTTPBody::appendFileRange(..., const WebFileInfo&)

same patch.
Comment 11 Eric Seidel (no email) 2010-09-18 03:21:29 PDT 
Comment on attachment 67773 [details]
patch #2: remove WebHTTPBody::appendFileRange(..., const WebFileInfo&)

Cleared Darin Fisher's review+ from obsolete attachment 67773 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 12 Dumitru Daniliuc 2010-09-30 13:02:32 PDT 
re-landed: r68818.