Bug 45823 - [Chromium] Convert WebCore.gyp to use regexp to excludes files instead of listing them in 'sources!'.
Summary: [Chromium] Convert WebCore.gyp to use regexp to excludes files instead of lis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-15 09:48 PDT by Marc-Antoine Ruel
Modified: 2010-09-16 06:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.43 KB, patch)
2010-09-15 09:54 PDT, Marc-Antoine Ruel 		no flags Details | Formatted Diff | Diff
Patch (13.43 KB, patch)
2010-09-15 11:03 PDT, Marc-Antoine Ruel 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-Antoine Ruel 2010-09-15 09:48:09 PDT 
Convert WebCore.gyp to use regexp to excludes files instead of listing them in 'sources!'.

This is necessary because 'sources!' is processed before 'sources/'. This makes
applying broader pattern in sources/ more difficult since it overrides the files
listed in sources!. Having all them in sources/ permits controlling the ordering
of the regexp, thus the final list of included files.

Fix Harfbuzz and VDMX source files includes in WebCore.gypi and WebCore.gyp
Comment 1 Marc-Antoine Ruel 2010-09-15 09:54:09 PDT 
Created attachment 67685 [details]
Patch
Comment 2 Marc-Antoine Ruel 2010-09-15 11:03:32 PDT 
Created attachment 67690 [details]
Patch
Comment 3 Dimitri Glazkov (Google) 2010-09-15 12:36:26 PDT 
Comment on attachment 67690 [details]
Patch

ok.
Comment 4 WebKit Commit Bot 2010-09-16 06:03:12 PDT 
Comment on attachment 67690 [details]
Patch

Clearing flags on attachment: 67690

Committed r67611: <http://trac.webkit.org/changeset/67611>
Comment 5 WebKit Commit Bot 2010-09-16 06:03:17 PDT 
All reviewed patches have been landed.  Closing bug.