Bug 45815 – Allow the embedder to specify the base path for IndexedDB.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jeremy Orlow]

Allow the embedder to specify the base path for IndexedDB.

[Jeremy Orlow]

Created attachment 67665 [details]
Patch

[Andrei Popescu]

 WebKit/chromium/public/WebIDBFactory.h
> open(name, description, callbacks, origin, webFrame, "/tmp/temporary-indexed-db-files");

Why do we need the string at the end? Can it just be the empty string?

[Jeremy Orlow]

(In reply to comment #2)
>  WebKit/chromium/public/WebIDBFactory.h
> > open(name, description, callbacks, origin, webFrame, "/tmp/temporary-indexed-db-files");
> 
> Why do we need the string at the end? Can it just be the empty string?

It's so things don't break mid-roll.  I'll then land the other half, and then we remove this.  Using this directory is actually the current behavior.

[Steve Block]

Comment on attachment 67665 [details]
Patch

> +    String path = ":memory:";
Presumably this is a magic value interpreted by SQLiteDatabase? Isn't there a constant you can use for the string?

[Jeremy Orlow]

(In reply to comment #4)
> (From update of attachment 67665 [details])
> > +    String path = ":memory:";
> Presumably this is a magic value interpreted by SQLiteDatabase? Isn't there a constant you can use for the string?

Even SQLite's internal code hard codes the string rather than using a constant, so I'm pretty sure not.

[Steve Block]

Comment on attachment 67665 [details]
Patch

OK, probably not worth using a local constant for just a single use

[Jeremy Orlow]

Committed r67605: <http://trac.webkit.org/changeset/67605>