Bug 45807 - Web Inspector: Multiline console does not work on Windows / Linux
Summary: Web Inspector: Multiline console does not work on Windows / Linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-14 23:46 PDT by Pavel Feldman
Modified: 2010-11-05 07:27 PDT (History)
11 users (show)

See Also:

Attachments
[PATCH] Proposed fix. (951 bytes, patch)
2010-09-14 23:49 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-09-14 23:46:31 PDT 
Reason: Alt+Enter is handled before it gets to the inspected page.

I'll add Ctrl+Enter handler and make it work on all platforms. As a result, Mac users get Alt | Ctrl, Linux and Windows users get Ctrl+Enter.
Comment 1 Pavel Feldman 2010-09-14 23:49:11 PDT 
Created attachment 67648 [details]
[PATCH] Proposed fix.
Comment 2 WebKit Commit Bot 2010-09-15 02:44:47 PDT 
Comment on attachment 67648 [details]
[PATCH] Proposed fix.

Clearing flags on attachment: 67648

Committed r67545: <http://trac.webkit.org/changeset/67545>
Comment 3 WebKit Commit Bot 2010-09-15 02:44:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Andy E 2010-11-05 06:00:02 PDT 
Why isn't it Shift + Enter?  Most instant messaging apps use Shift+Enter for multi-line messages and Firefox's console uses the same combination.

Shift+Enter would feel more natural for most Windows users, please change this.
Comment 5 Pavel Feldman 2010-11-05 07:27:25 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/NetworkPanel.js
	M	WebCore/inspector/front-end/StoragePanel.js
	M	WebCore/inspector/front-end/inspector.js
Committed r71413

(added shift+Enter modifier as a drive-by)