Bug 45799 – bugs.webkit.org should autocomplete WebKit Committers and Reviewers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

bugs.webkit.org should autocomplete WebKit Committers and Reviewers

[Adam Barth]

Created attachment 67633 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 67633 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67633&action=prettypatch

> BugsSite/template/en/default/global/footer.html.tmpl:46
> +<script src="/committers-autocomplete.js"></script>
Should this really be on every page?  Also seems we should use the new defer or async hotness.

I think Ojan and wms should see this, but looks sane to me.

[Eric Seidel (no email)]

CCing bugzilla hackers.  It's sooo sooo sad that bugzilla doesn't have this, even in new versions it seems.  We really should be pulling from bugzilla's own user list.

If we're not going to pull from bugzilla's user list, then we have the popup have a link to explain where this list comes from and how to fix it.  Many of the emails it choses are wrong.

[Adam Barth]

Committed r67528: <http://trac.webkit.org/changeset/67528>

[Ojan Vafai]

> CCing bugzilla hackers.  It's sooo sooo sad that bugzilla doesn't have this, even in new versions it seems.  We really should be pulling from bugzilla's own user list.
> 
> If we're not going to pull from bugzilla's user list, then we have the popup have a link to explain where this list comes from and how to fix it.  Many of the emails it choses are wrong.

The only time it chooses the wrong one is when the person's bugzilla email address is not the first one listed in committers.py. There are other scripts that expect the first entry to be the bugzilla address as well, so this isn't the only thing that would break.

I'm not sure we really want it to pull from bugzilla's user list. For example, I have my personal email address in bugzilla as well, but I don't want people CCing that address by mistake. Maybe we could have the entry in committers.py override bugzilla? In either case, with the exception of the issue above, I think what's here works fine.

Eric beat me to the r+. I'm happy to kill the extension. It was only an extension to start with in order to get around cross-domain request restrictions.

> BugsSite/committers-autocomplete.js:384
> +    WebKitCommitters.getCommitters(function (committers) {
Not sure it's worth keeping this a separate object. It was just done that way to work with the way extensions work (i.e. the injected script can't access committers.py.

[Adam Barth]

I did it that way because I expect other scripts to use it in the future ....