Bug 45797 - [BREWMP] Port TextCodec
Summary: [BREWMP] Port TextCodec
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 33564
  Show dependency treegraph
Reported: 2010-09-14 17:57 PDT by Kwang Yul Seo
Modified: 2010-10-16 14:05 PDT (History)
1 user (show)

See Also:

Patch (13.19 KB, patch)
2010-09-14 18:10 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (13.22 KB, patch)
2010-10-01 14:45 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-09-14 17:57:12 PDT
Implement TextCodec with Brew MP's ICharsetConv.
Comment 1 Kwang Yul Seo 2010-09-14 18:10:40 PDT
Created attachment 67628 [details]

Support only UTF-8 for now.
Comment 2 Kwang Yul Seo 2010-10-01 14:45:27 PDT
Created attachment 69523 [details]

Append L'?' on AEE_BADITEM when stopOnError is set. Otherwise, Acid 3 test 70 fails.
Comment 4 Kent Tamura 2010-10-14 17:56:03 PDT
Comment on attachment 69523 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=69523&action=review

> WebCore/platform/text/brew/TextCodecBrew.cpp:195
> +

This blank line seems unnecessary.
Comment 5 Kwang Yul Seo 2010-10-16 14:05:11 PDT
Manually committed r69917: http://trac.webkit.org/changeset/69917
Comment 6 Kwang Yul Seo 2010-10-16 14:05:45 PDT
All reviewed patches have been landed.  Closing bug.