Bug 45796 – Remaining discrepancies in piecewise text measurement

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Brad Moore]

As illustrated in:

https://bugs.webkit.org/show_bug.cgi?id=42279

We have to be careful about summing floating point widths.  There's still a remaining case in which width(" string") may not equal width(" ") + width("string").

[Brad Moore]

Created attachment 68383 [details]
patch to width iterator

[WebKit Review Bot]

Attachment 68383 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/graphics/WidthIterator.cpp:224:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 68383 [details]
patch to width iterator

View in context: https://bugs.webkit.org/attachment.cgi?id=68383&action=review

> WebCore/platform/graphics/WidthIterator.cpp:224
> +            ASSERT(widthSinceLastRounding == 0);

Like the style checker mentioned, WebKit style is to write this as ASSERT(!widthSinceLastRounding);

Fixed in <http://trac.webkit.org/projects/webkit/changeset/68148>.