RESOLVED FIXED 45789
WebKit should use system wide spell checking preference when application specific one isn't set. 
https://bugs.webkit.org/show_bug.cgi?id=45789
Summary WebKit should use system wide spell checking preference when application spec...
Jia Pu
Reported 2010-09-14 16:09:45 PDT
On Mac OSX, we want WebKit to use the new global preferences for spelling correction and text replacement when user doesn't set application specific preference value. <rdar://problem/8416041>
Attachments
Proposed patch (v1) (1.72 KB, patch)
2010-09-14 16:19 PDT, Jia Pu 		no flags
DetailsFormatted DiffDiff
Proposed patch (v2) (1.75 KB, patch)
2010-09-14 17:43 PDT, Jia Pu 		no flags
DetailsFormatted DiffDiff
Proposed patch (v3) (1.75 KB, patch)
2010-09-14 19:45 PDT, Jia Pu 		no flags
DetailsFormatted DiffDiff
Proposed patch (v4) (2.14 KB, patch)
2010-09-16 22:22 PDT, Jia Pu 		mitz: review+
mitz: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jia Pu
Comment 1 2010-09-14 16:19:12 PDT
Created attachment 67618 [details] Proposed patch (v1)
mitz
Comment 2 2010-09-14 17:27:24 PDT
Comment on attachment 67618 [details] Proposed patch (v1) Are there any notifications we should listen to for when the systemwide settings change? Also, please make sure to leave in the Reviewed by NOBODY (OOPS).
Jia Pu
Comment 3 2010-09-14 17:43:42 PDT
Created attachment 67624 [details] Proposed patch (v2) Added back "Reviewed by NOBODY (OOPS!)." line, so that build doesn't fail.
Jia Pu
Comment 4 2010-09-14 17:45:02 PDT
(In reply to comment #2) > (From update of attachment 67618 [details]) > Are there any notifications we should listen to for when the systemwide settings change? Eventually yes, we would post notification for setting changes. But we'd like to get this in for now.
Jia Pu
Comment 5 2010-09-14 19:39:49 PDT
Comment on attachment 67624 [details] Proposed patch (v2) I manually added "Reviewed by NOBODY (OOPS)." line without changing the line range. So the patch is malformed. I will submit another patch.
Jia Pu
Comment 6 2010-09-14 19:45:22 PDT
Created attachment 67636 [details] Proposed patch (v3) Updated ChangeLog with "Reviewed by NOBODY (OOPS!)." line.
WebKit Commit Bot
Comment 7 2010-09-14 21:09:53 PDT
Comment on attachment 67636 [details] Proposed patch (v3) Clearing flags on attachment: 67636 Committed r67533: <http://trac.webkit.org/changeset/67533>
WebKit Commit Bot
Comment 8 2010-09-14 21:09:58 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 9 2010-09-14 22:45:59 PDT
http://trac.webkit.org/changeset/67533 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67531 http://trac.webkit.org/changeset/67532 http://trac.webkit.org/changeset/67533
Mark Rowe (bdash)
Comment 10 2010-09-15 00:21:47 PDT
This broke the build. Jia, see your email for details. I rolled it out in r67539.
Jia Pu
Comment 11 2010-09-16 22:22:25 PDT
Created attachment 67884 [details] Proposed patch (v4) Fixed build failure.
mitz
Comment 12 2010-09-17 00:14:24 PDT
Comment on attachment 67884 [details] Proposed patch (v4) View in context: https://bugs.webkit.org/attachment.cgi?id=67884&action=prettypatch > WebKit/mac/WebView/WebView.mm:109 > +#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD) > +#import <AppKit/NSTextChecker.h> > +#endif When an #import or #include directive is in an #if block, that block usually appears as a separate paragraph after the main #import paragraph. I will make this change when I land the patch.
mitz
Comment 13 2010-09-17 00:20:55 PDT
Fixed in <http://trac.webkit.org/projects/webkit/changeset/67696>.
WebKit Review Bot
Comment 14 2010-09-17 06:41:44 PDT
http://trac.webkit.org/changeset/67696 might have broken GTK Linux 32-bit Debug
Note You need to log in before you can comment on or make changes to this bug.