Bug 45786 - Make it possible to run more than one commit-queue instance
Summary: Make it possible to run more than one commit-queue instance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 44292
  Show dependency treegraph
 
Reported: 2010-09-14 15:42 PDT by Eric Seidel (no email)
Modified: 2010-09-15 15:43 PDT (History)
1 user (show)

See Also:


Attachments
Patch (8.93 KB, patch)
2010-09-14 15:56 PDT, Eric Seidel (no email)
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-09-14 15:42:53 PDT
Make it possible to run more than one commit-queue instance
Comment 1 Eric Seidel (no email) 2010-09-14 15:56:40 PDT
Created attachment 67615 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-09-14 16:03:54 PDT
See http://queues.webkit.org/next-patch/commit-queue.  Compare that with the list of patches in queue at http://queues.webkit.org/queue-status/commit-queue.  Notice how it is returning the first patch which has not been touched in the last hour. :)
Comment 3 Adam Barth 2010-09-14 16:21:11 PDT
Comment on attachment 67615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67615&action=prettypatch

> WebKitTools/QueueStatusServer/handlers/nextpatch.py:52
> +    def get(self, queue_name):
> +        self.response.out.write(self._get_next_patch_id(queue_name))
We should use 404 if there's no next patch.  REST and all that.

> WebKitTools/Scripts/webkitpy/tool/commands/queues.py:156
> +    def _fetch_next_work_item(self):
> +        self.tool.status_server.next_work_item(self.name)
No return?

> WebKitTools/Scripts/webkitpy/tool/commands/queues.py:219
> +        log("Error: status server returned patch id %s which is not one I sent to it.")
> +        return None
Why is this an error?  It could have been put there by another instance of this queue.
Comment 4 Eric Seidel (no email) 2010-09-15 15:43:46 PDT
Committed r67572: <http://trac.webkit.org/changeset/67572>