Bug 45785 – Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sam Weinig]

Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.

[Sam Weinig]

Created attachment 67614 [details]
Patch

All tests pass.

[Anders Carlsson]

Comment on attachment 67614 [details]
Patch

> Index: WebKitTools/ChangeLog
> ===================================================================
> --- WebKitTools/ChangeLog	(revision 67503)
> +++ WebKitTools/ChangeLog	(working copy)
> @@ -1,3 +1,28 @@
> [phone]  Sam Weinig  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
> +        https://bugs.webkit.org/show_bug.cgi?id=45785
> +
> +        * MiniBrowser/mac/AppDelegate.m:
> +        (-[BrowserAppDelegate init]):

I don't think you intended to add this.

> Index: WebKitTools/MiniBrowser/mac/AppDelegate.m
> ===================================================================
> --- WebKitTools/MiniBrowser/mac/AppDelegate.m	(revision 67475)
> +++ WebKitTools/MiniBrowser/mac/AppDelegate.m	(working copy)
> @@ -32,7 +32,7 @@
>  #import <WebKit2/WKStringCF.h>
>  #import <WebKit2/WKURLCF.h>
>  
> -static NSString *defaultURL = @"http://www.webkit.org/";
> +static NSString *defaultURL = @"http://www.tivofaq.com/";
>  
>  @implementation BrowserAppDelegate
>  
> @@ -113,10 +113,7 @@ - (id)init
>  {
>      self = [super init];
>      if (self) {
> -        if ([NSEvent modifierFlags] & NSShiftKeyMask)
> -            currentProcessModel = kProcessModelSharedSecondaryThread;
> -        else
> -            currentProcessModel = kProcessModelSharedSecondaryProcess;
> +        currentProcessModel = kProcessModelSharedSecondaryThread;
>  
>          WKContextRef threadContext = WKContextGetSharedThreadContext();
>          WKContextHistoryClient historyClient = {

Or this. Looks fine otherwise!

[WebKit Review Bot]

Attachment 67614 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Landed in r67507.

[WebKit Review Bot]

http://trac.webkit.org/changeset/67507 might have broken Leopard Intel Debug (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/67506
http://trac.webkit.org/changeset/67507