Bug 45785 - Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
Summary: Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-14 15:39 PDT by Sam Weinig
Modified: 2010-09-14 19:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (32.52 KB, patch)
2010-09-14 15:41 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-09-14 15:39:57 PDT 
Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
Comment 1 Sam Weinig 2010-09-14 15:41:34 PDT 
Created attachment 67614 [details]
Patch

All tests pass.
Comment 2 Anders Carlsson 2010-09-14 15:45:04 PDT 
Comment on attachment 67614 [details]
Patch

> Index: WebKitTools/ChangeLog
> ===================================================================
> --- WebKitTools/ChangeLog	(revision 67503)
> +++ WebKitTools/ChangeLog	(working copy)
> @@ -1,3 +1,28 @@
> +2010-09-14  Sam Weinig  <sam@webkit.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
> +        https://bugs.webkit.org/show_bug.cgi?id=45785
> +
> +        * MiniBrowser/mac/AppDelegate.m:
> +        (-[BrowserAppDelegate init]):

I don't think you intended to add this.

> Index: WebKitTools/MiniBrowser/mac/AppDelegate.m
> ===================================================================
> --- WebKitTools/MiniBrowser/mac/AppDelegate.m	(revision 67475)
> +++ WebKitTools/MiniBrowser/mac/AppDelegate.m	(working copy)
> @@ -32,7 +32,7 @@
>  #import <WebKit2/WKStringCF.h>
>  #import <WebKit2/WKURLCF.h>
>  
> -static NSString *defaultURL = @"http://www.webkit.org/";
> +static NSString *defaultURL = @"http://www.tivofaq.com/";
>  
>  @implementation BrowserAppDelegate
>  
> @@ -113,10 +113,7 @@ - (id)init
>  {
>      self = [super init];
>      if (self) {
> -        if ([NSEvent modifierFlags] & NSShiftKeyMask)
> -            currentProcessModel = kProcessModelSharedSecondaryThread;
> -        else
> -            currentProcessModel = kProcessModelSharedSecondaryProcess;
> +        currentProcessModel = kProcessModelSharedSecondaryThread;
>  
>          WKContextRef threadContext = WKContextGetSharedThreadContext();
>          WKContextHistoryClient historyClient = {

Or this. Looks fine otherwise!
Comment 3 WebKit Review Bot 2010-09-14 15:47:39 PDT 
Attachment 67614 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Sam Weinig 2010-09-14 15:53:48 PDT 
Landed in r67507.
Comment 5 WebKit Review Bot 2010-09-14 19:44:19 PDT 
http://trac.webkit.org/changeset/67507 might have broken Leopard Intel Debug (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/67506
http://trac.webkit.org/changeset/67507