Bug 45783 - LayoutTest fast/dom/Geolocation/clear-watch-invalid-id-crash.html is flaky
Summary: LayoutTest fast/dom/Geolocation/clear-watch-invalid-id-crash.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-14 14:39 PDT by Steve Block
Modified: 2010-09-15 03:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.41 KB, patch)
2010-09-14 14:53 PDT, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-09-14 14:39:18 PDT
Fix LayoutTest fast/dom/Geolocation/clear-watch-invalid-id-crash.html contains a race condition so is flaky.

This test synchronously navigates the page to a new URL from its main script file. This navigation causes WebView.onPageFinished() to be called for the test page. The problem is that this may occur before js-test-post.js, which is included by the test and calls layoutTestController.waitUntilDone(), is loaded and parsed. As a result, the test is incorrectly deemed to have finished as soon as the navigation is started and the output will therefore be incorrect.
Comment 1 Steve Block 2010-09-14 14:53:30 PDT
Created attachment 67610 [details]
Patch
Comment 2 WebKit Commit Bot 2010-09-15 03:06:20 PDT
Comment on attachment 67610 [details]
Patch

Clearing flags on attachment: 67610

Committed r67546: <http://trac.webkit.org/changeset/67546>
Comment 3 WebKit Commit Bot 2010-09-15 03:06:25 PDT
All reviewed patches have been landed.  Closing bug.