Bug 45781 - Sort with non-numeric custom sort function fails on array with length but no values
Summary: Sort with non-numeric custom sort function fails on array with length but no ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-14 13:54 PDT by Darin Adler
Modified: 2010-09-14 22:11 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.62 KB, patch)
2010-09-14 13:56 PDT, Darin Adler
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2010-09-14 13:54:29 PDT
Sort with non-numeric custom sort function fails on array with length but no values
Comment 1 Darin Adler 2010-09-14 13:55:09 PDT
Someone ran into this at the FedEx website.
Comment 2 Darin Adler 2010-09-14 13:56:50 PDT
Created attachment 67601 [details]
Patch
Comment 3 Geoffrey Garen 2010-09-14 14:03:26 PDT
Comment on attachment 67601 [details]
Patch

r=me
Comment 4 Darin Adler 2010-09-14 14:06:22 PDT
Committed r67494: <http://trac.webkit.org/changeset/67494>
Comment 5 WebKit Review Bot 2010-09-14 14:44:11 PDT
http://trac.webkit.org/changeset/67494 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/67496
http://trac.webkit.org/changeset/67494
http://trac.webkit.org/changeset/67495
Comment 7 Eric Seidel (no email) 2010-09-14 15:47:22 PDT
webkit-patch rebaseline
can pull down the results for failing builders for you.
Comment 8 Eric Seidel (no email) 2010-09-14 15:47:51 PDT
(webkit-patch rebaseline is super-alpha though, so it may not always do what you want!)
Comment 9 Darin Adler 2010-09-14 22:11:32 PDT
I accidentally landed the wrong expected results, Geoff fixed them later. It’s a mystery to me why every builder didn’t fail!