Bug 45776 - [Qt] Zoom factor for checkboxes and radios.
Summary: [Qt] Zoom factor for checkboxes and radios.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Luiz Agostini
URL:
Keywords: Qt
Depends on:
Blocks: 41847
  Show dependency tree / graph
 
Reported: 2010-09-14 13:08 PDT by Luiz Agostini
Modified: 2010-09-16 00:33 PDT (History)
5 users (show)

See Also:

Attachments
patch (2.61 KB, patch)
2010-09-14 13:14 PDT, Luiz Agostini 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2010-09-14 13:08:05 PDT 
RenderThemeQt does not consider RenderStyle::effectiveZoom when calculating sizes of checkboxes and radios.

Even with this change the used QStyle must support different sizes for radios and checkboxes. QWindowStyle and QMacStyle, for example, do not.
For testing I used Maemo5WebStyle class (WebCore/platform/qt/Maemo5WebStyle.h). This style may be put into use by passing CONFIG+=use_qt_mobile_theme to build-webkit.
Comment 1 Luiz Agostini 2010-09-14 13:14:06 PDT 
Created attachment 67595 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2010-09-14 13:15:12 PDT 
Comment on attachment 67595 [details]
patch

I trust you on this, r=me.
Comment 3 WebKit Commit Bot 2010-09-14 20:37:39 PDT 
Comment on attachment 67595 [details]
patch

Clearing flags on attachment: 67595

Committed r67531: <http://trac.webkit.org/changeset/67531>
Comment 4 WebKit Commit Bot 2010-09-14 20:37:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-09-14 22:45:42 PDT 
http://trac.webkit.org/changeset/67531 might have broken GTK Linux 32-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/67531
http://trac.webkit.org/changeset/67532
http://trac.webkit.org/changeset/67533
Comment 6 Simon Hausmann 2010-09-16 00:33:50 PDT 
Revision r67531 cherry-picked into qtwebkit-2.1 with commit 94645f6b86d1fe64e7c39c8915b8aef244444270