45771 – [Qt] V8 port: Get inspector up and running

Bug 45771 - [Qt] V8 port: Get inspector up and running

Summary: [Qt] V8 port: Get inspector up and running

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebCore Misc. (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	QtWebKit Unassigned

URL:
Keywords:	Qt, QtTriaged

Depends on:
Blocks:

Reported:	2010-09-14 12:44 PDT by Andreas Kling
Modified:	2010-09-14 14:56 PDT (History)
CC List:	3 users (show)

See Also:

Attachments
Proposed patch (3.35 KB, patch) 2010-09-14 12:53 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andreas Kling 2010-09-14 12:44:53 PDT

For the inspector to function in the V8 port, we need to load WebCore/bindings/v8/DebuggerScript.js into ScriptDebugServer before firing up the inspector.

Comment 1 Andreas Kling 2010-09-14 12:53:45 PDT

Created attachment 67590 [details]
Proposed patch

Comment 2 Kenneth Rohde Christiansen 2010-09-14 13:03:22 PDT

Comment on attachment 67590 [details]
Proposed patch

r=me

Comment 3 Andreas Kling 2010-09-14 13:08:18 PDT

Comment on attachment 67590 [details]
Proposed patch

Clearing flags on attachment: 67590

Committed r67488: <http://trac.webkit.org/changeset/67488>

Comment 4 Andreas Kling 2010-09-14 13:08:27 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 WebKit Review Bot 2010-09-14 14:56:12 PDT

http://trac.webkit.org/changeset/67488 might have broken GTK Linux 32-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/67488
http://trac.webkit.org/changeset/67489
http://trac.webkit.org/changeset/67490
http://trac.webkit.org/changeset/67485
http://trac.webkit.org/changeset/67486
http://trac.webkit.org/changeset/67487