RESOLVED FIXED45759
Web Inspector: small refactoring for monitoringXHR flag. 
https://bugs.webkit.org/show_bug.cgi?id=45759
Summary Web Inspector: small refactoring for monitoringXHR flag.
Ilya Tikhonovsky
Reported 2010-09-14 09:22:17 PDT
Our Inspector API is quite big and can be simplified a bit. As example for single backend property like monitoringXHR we have 4 functions in the API. Two functions for frontend enableMonitoringXHR/disableMonitoringXHR and two functions for backend monitoringXHRWasEnabled and monitoringXHRWasDisabled. These functions can be replaced by one setMonitoringXHR with one 'in' and one 'out' argument. The initial state of the flag can be gathered from backend with help of getSettings call where additional section was added for backend state information.
Attachments
[patch] initial version. (14.19 KB, patch)
2010-09-14 09:52 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
[patch] initial version. text version :). (11.84 KB, patch)
2010-09-14 09:59 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2010-09-14 09:52:24 PDT
Created attachment 67568 [details] [patch] initial version.
Yury Semikhatsky
Comment 2 2010-09-14 09:57:34 PDT
The diff is corrupted.
Ilya Tikhonovsky
Comment 3 2010-09-14 09:59:39 PDT
Created attachment 67570 [details] [patch] initial version. text version :).
Yury Semikhatsky
Comment 4 2010-09-14 10:17:35 PDT
Comment on attachment 67570 [details] [patch] initial version. text version :). View in context: https://bugs.webkit.org/attachment.cgi?id=67570&action=prettypatch > WebCore/inspector/InspectorController.cpp:-130 > -static const char* const monitoringXHRSettingName = "xhrMonitor"; Please make sure that it won't break existing clients. > WebCore/inspector/InspectorController.cpp:251 > +String InspectorController::getBackendState() The name sounds too general.
Ilya Tikhonovsky
Comment 5 2010-09-15 04:21:36 PDT
Comments addressed. Committed r67547 M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/Inspector.idl M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/Settings.js M WebCore/inspector/front-end/inspector.js M WebCore/inspector/InspectorController.h M LayoutTests/http/tests/inspector/console-xhr-logging.html M LayoutTests/inspector/report-API-errors.html M LayoutTests/ChangeLog r67547 = 28831a1ed2fb529f442aa99d1ddbb5a1f5e0423f (refs/remotes/trunk)
Note You need to log in before you can comment on or make changes to this bug.