Bug 45756 - Web Inspector: Links from "Profiles" don't lead to "Scripts"
: Web Inspector: Links from "Profiles" don't lead to "Scripts"
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-09-14 08:49 PST by
Modified: 2010-09-14 18:43 PST (History)


Attachments
screenshot of where to click (81.91 KB, image/png)
2010-09-14 08:51 PST, Alexei Masterov
no flags Details
Patch (4.66 KB, patch)
2010-09-14 10:10 PST, Yury Semikhatsky
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-09-14 08:49:12 PST
Steps to reproduce:

1. navigate to a page with javascript (http://www.google.com/ for example)
2. open inspector by pressing CMD+ALT+i
3. select the "Profiles" tab, enable profiling if necessary, and click the Record button to record the CPU profile
4. execute some javascript action and click the Record button again to stop recording
5. Click on a link to the source code on the right hand side of the panel (see attached screenshot)

Desired outcome:
Inspector opens the "Scripts" panel with the function call selected

What happens instead:
"Resources" panel opens, and the corresponding file is selected

NOTE: if the scripts panel was accessed previously, the behavior may be different, so please use a freshly opened instance to repro
------- Comment #1 From 2010-09-14 08:51:28 PST -------
Created an attachment (id=67557) [details]
screenshot of where to click
------- Comment #2 From 2010-09-14 10:10:04 PST -------
Created an attachment (id=67573) [details]
Patch
------- Comment #3 From 2010-09-14 10:43:29 PST -------
(From update of attachment 67573 [details])
Wrt WebInspector.documentMouseOver: I think it was used for lazy calculation of the tooltip text. Should be fine to nuke useless thingy.
------- Comment #4 From 2010-09-14 12:38:29 PST -------
> (From update of attachment 67573 [details] [details])
> Wrt WebInspector.documentMouseOver: I think it was used for lazy calculation
> of the tooltip text. Should be fine to nuke useless thingy.

It was originally added (with a real implementation) for:
<http://webkit.org/b/35574> Web Inspector: Nothing happens on navigation to resource via a link if resource tracking is disabled

How is that handled now? I don't know when the related code was removed, but it
does look like all the related code was removed.
------- Comment #5 From 2010-09-14 18:43:27 PST -------
(From update of attachment 67573 [details])
Clearing flags on attachment: 67573

Committed r67525: <http://trac.webkit.org/changeset/67525>
------- Comment #6 From 2010-09-14 18:43:32 PST -------
All reviewed patches have been landed.  Closing bug.