RESOLVED INVALID 45755
[Qt] TestNetscapePlugIn.dll to compile from .pro in Windows 
https://bugs.webkit.org/show_bug.cgi?id=45755
Summary [Qt] TestNetscapePlugIn.dll to compile from .pro in Windows
Janne Koskinen
Reported 2010-09-14 08:34:08 PDT
Currently TestNetscapePlugIn.dll needs to be compiled separately from Qt using visual studio project. Problem is that the project file doesn't work with MSVC2008. I assume it requires MSVC6 but I do not have that in hand. patch incoming...
Attachments
proposed fix for TestNetscapePlugIn (2.68 KB, patch)
2010-09-14 08:45 PDT, Janne Koskinen 		koshuin: review-
koshuin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Janne Koskinen
Comment 1 2010-09-14 08:45:41 PDT
Created attachment 67556 [details] proposed fix for TestNetscapePlugIn This patch generates one warning about library statement mismatch. Fix for that can be done by editing TestNetscapePlugin.def by removing np prefix out of the target library. I didn't change this as I do not have VC6 to verify if it would break that build. Looking at the code it won't, but maybe there is someone still relying on prefixed npapi plugins like stated in Mozilla documentations i.e. filename 8.3 and starts with np - prefix.
Early Warning System Bot
Comment 2 2010-09-14 08:52:14 PDT
Attachment 67556 [details] did not build on qt: Build output: http://queues.webkit.org/results/4064002
WebKit Review Bot
Comment 3 2010-09-14 08:52:17 PDT
Attachment 67556 [details] did not build on gtk: Build output: http://queues.webkit.org/results/4062009
WebKit Review Bot
Comment 4 2010-09-14 10:11:16 PDT
Attachment 67556 [details] did not build on win: Build output: http://queues.webkit.org/results/3998012
Janne Koskinen
Comment 5 2010-09-14 23:46:10 PDT
Darn I forgot to add the include directory to all other environments.
Note You need to log in before you can comment on or make changes to this bug.