RESOLVED FIXED Bug 45747
[Qt] qmake doesn't generate correct dependencies for rcc resource files 
https://bugs.webkit.org/show_bug.cgi?id=45747
Summary [Qt] qmake doesn't generate correct dependencies for rcc resource files
Andras Becsi
Reported 2010-09-14 06:54:52 PDT
Due to a bug of qmake it didn't generate a correct Makefile for WebCore and the rcc resource files miss the dependencies to js, css and png files which are needed by WebInspector, and this caused incremental build issues in QtWebKit. Hitherto the bots had a local workaround for this issue, but b139e7e96e5c47b412c4f0bbc4ae11d5cca99e61 (http://qt.gitorious.org/qt) - QTBUG-1918 fixed the issue partially and WebCore.pri only needs a small change to get correct dependencies.
Attachments
proposed patch (824 bytes, patch)
2010-09-14 06:59 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2010-09-14 06:59:56 PDT
Created attachment 67545 [details] proposed patch
Csaba Osztrogonác
Comment 2 2010-09-14 07:00:37 PDT
Comment on attachment 67545 [details] proposed patch LGTM, r=me. Thx for the fix.
Andras Becsi
Comment 3 2010-09-14 07:05:02 PDT
Comment on attachment 67545 [details] proposed patch Clearing flags on attachment: 67545 Committed r67465: <http://trac.webkit.org/changeset/67465>
Andras Becsi
Comment 4 2010-09-14 07:05:09 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2010-09-14 09:13:58 PDT
http://trac.webkit.org/changeset/67465 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67465 http://trac.webkit.org/changeset/67466 http://trac.webkit.org/changeset/67467 http://trac.webkit.org/changeset/67468
Note You need to log in before you can comment on or make changes to this bug.