Bug 45745 - [Qt] Cookie operations should use NetworkingContext
Summary: [Qt] Cookie operations should use NetworkingContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-14 05:03 PDT by Balazs Kelemen
Modified: 2010-09-14 06:18 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (1.59 KB, patch)
2010-09-14 05:12 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff
proposed patch v2 (1.54 KB, patch)
2010-09-14 05:53 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-09-14 05:03:55 PDT
Like we changed ResourceHandle in http://trac.webkit.org/changeset/67291 to get the QNetworkAccessManager from the NetworkingContext we should change the cookie operations in CookieJarQt.cpp. Currently we are crashing with WebKit2.
Comment 1 Balazs Kelemen 2010-09-14 05:12:09 PDT
Created attachment 67541 [details]
proposed patch
Comment 2 Balazs Kelemen 2010-09-14 05:53:07 PDT
Created attachment 67543 [details]
proposed patch v2

Corrected the NetworkingContext usage: use the loader to obtaining it.
Comment 3 Andreas Kling 2010-09-14 05:58:40 PDT
Comment on attachment 67543 [details]
proposed patch v2

> +        No new functionality so new tests.
Missing "no"

r=me
Comment 4 Andras Becsi 2010-09-14 06:17:05 PDT
Committed r67461: <http://trac.webkit.org/changeset/67461>
Comment 5 Andras Becsi 2010-09-14 06:18:15 PDT
Comment on attachment 67543 [details]
proposed patch v2

Clearing flags.