Bug 45741 – [EFL] ewk_frame_view_create_for_view set null as theme.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

I traced below message and I found that ewk_fram_view_create_for_view calls setEdjeTheme with null argument.

ERR: /workspace/webkit/WebCore/platform/efl/ScrollbarEfl.cpp:119 setParent() Could not load theme 'scrollbar.vertical': no theme path set.
ERR: /workspace/webkit/WebCore/platform/efl/ScrollbarEfl.cpp:119 setParent() Could not load theme 'scrollbar.horizontal': no theme path set.

[Ryuan Choi]

Created attachment 67535 [details]
Patch

[Lucas De Marchi]

Comment on attachment 67535 [details]
Patch

> Index: WebKit/efl/ewk/ewk_frame.cpp
> ===================================================================
> --- WebKit/efl/ewk/ewk_frame.cpp	(revision 67458)
> +++ WebKit/efl/ewk/ewk_frame.cpp	(working copy)
> @@ -1962,7 +1962,9 @@ void ewk_frame_view_create_for_view(Evas
>      sd->frame->createView(size, bg, !a, WebCore::IntSize(), false);
>      if (!sd->frame->view())
>          return;
> -    sd->frame->view()->setEdjeTheme(sd->theme);
> +
> +    const char * theme = ewk_view_theme_get(view);
                  `---- Extra space here.

Otherwise, it looks good.

[Ryuan Choi]

Created attachment 67537 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 67537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67537&action=prettypatch

When you upload a new patch, please say what you changed. Like "fixed above comments".

[WebKit Commit Bot]

Comment on attachment 67537 [details]
Patch

Clearing flags on attachment: 67537

Committed r67519: <http://trac.webkit.org/changeset/67519>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.