Bug 45741 - [EFL] ewk_frame_view_create_for_view set null as theme.
Summary: [EFL] ewk_frame_view_create_for_view set null as theme.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-14 04:15 PDT by Ryuan Choi
Modified: 2010-09-14 17:35 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.44 KB, patch)
2010-09-14 04:25 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (2.44 KB, patch)
2010-09-14 04:56 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2010-09-14 04:15:03 PDT
I traced below message and I found that ewk_fram_view_create_for_view calls setEdjeTheme with null argument.

ERR: /workspace/webkit/WebCore/platform/efl/ScrollbarEfl.cpp:119 setParent() Could not load theme 'scrollbar.vertical': no theme path set.
ERR: /workspace/webkit/WebCore/platform/efl/ScrollbarEfl.cpp:119 setParent() Could not load theme 'scrollbar.horizontal': no theme path set.
Comment 1 Ryuan Choi 2010-09-14 04:25:01 PDT
Created attachment 67535 [details]
Patch
Comment 2 Lucas De Marchi 2010-09-14 04:48:27 PDT
Comment on attachment 67535 [details]
Patch

> Index: WebKit/efl/ewk/ewk_frame.cpp
> ===================================================================
> --- WebKit/efl/ewk/ewk_frame.cpp	(revision 67458)
> +++ WebKit/efl/ewk/ewk_frame.cpp	(working copy)
> @@ -1962,7 +1962,9 @@ void ewk_frame_view_create_for_view(Evas
>      sd->frame->createView(size, bg, !a, WebCore::IntSize(), false);
>      if (!sd->frame->view())
>          return;
> -    sd->frame->view()->setEdjeTheme(sd->theme);
> +
> +    const char * theme = ewk_view_theme_get(view);
                  `---- Extra space here.

Otherwise, it looks good.
Comment 3 Ryuan Choi 2010-09-14 04:56:01 PDT
Created attachment 67537 [details]
Patch
Comment 4 Kenneth Rohde Christiansen 2010-09-14 07:30:38 PDT
Comment on attachment 67537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67537&action=prettypatch

When you upload a new patch, please say what you changed. Like "fixed above comments".
Comment 5 WebKit Commit Bot 2010-09-14 17:35:08 PDT
Comment on attachment 67537 [details]
Patch

Clearing flags on attachment: 67537

Committed r67519: <http://trac.webkit.org/changeset/67519>
Comment 6 WebKit Commit Bot 2010-09-14 17:35:14 PDT
All reviewed patches have been landed.  Closing bug.