Bug 4574 – HTML parser does not put attributes on the <isindex> element

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Darin Adler]

The hack in the HTML parser that implements the <isindex> element does not put the attributes specified 
onto the element it creates.

[Darin Adler]

Created attachment 3497 [details]
patch to put attributes on <isindex>

This patch fixes the problem by putting the attributes on the <isindex> element
rather than on top level element, but the hack of using the DOM to implement
<isindex> is going to create other problems anyway, so we probably need to do a
better fix. For example, <isindex> doesn't work at all in XHTML.

It seems such a waste to spend any time at all on <isindex>. But this does fix
3 of the W3C tests.

[Darin Adler]

Obviously the real fix is to add <isindex> support rather than hacking it in the HTML parser.

[Darin Adler]

Comment on attachment 3497 [details]
patch to put attributes on <isindex>

Maybe we should land this even though it's not the "right" fix.

[Maciej Stachowiak]

Comment on attachment 3497 [details]
patch to put attributes on <isindex>

Seems fine to do this - the better fix can maybe wait until we have XBL.

[Darin Adler]

Funny you should say that -- I was thinking Dave would say the same thing.