WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
45739
Move DebuggerScript.js from WebKit/chromium to somewhere in WebCore
https://bugs.webkit.org/show_bug.cgi?id=45739
Summary
Move DebuggerScript.js from WebKit/chromium to somewhere in WebCore
Andreas Kling
Reported
2010-09-14 03:05:39 PDT
Since we need WebKit/chromium/src/js/DebuggerScript.js for QtWebKit when building against V8, it would make sense to move it to a non-port-specific directory in WebCore.
Attachments
Patch
(6.11 KB, patch)
2010-09-14 08:09 PDT
,
Yury Semikhatsky
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1
2010-09-14 07:17:42 PDT
This should have been done from the very beginning. I'll move the script into WebCore/bindings/v8 which looks like an appropriate place as it's used by WebCore/bindings/v8/ScriptDebugServer
Yury Semikhatsky
Comment 2
2010-09-14 08:09:25 PDT
Created
attachment 67553
[details]
Patch
Andreas Kling
Comment 3
2010-09-14 08:36:54 PDT
Comment on
attachment 67553
[details]
Patch LGTM
Yury Semikhatsky
Comment 4
2010-09-14 08:41:16 PDT
Comment on
attachment 67553
[details]
Patch Clearing flags on attachment: 67553 Committed
r67472
: <
http://trac.webkit.org/changeset/67472
>
Yury Semikhatsky
Comment 5
2010-09-14 08:41:29 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug