Bug 45728 – [EFL] Fix a build break by Bug 45494

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

There is a build break as below when WebKit EFL is built.

/home/gyuyoung/webkit/WebKit-git/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:681: error: virtual 
outside class declaration

[Gyuyoung Kim]

Created attachment 67510 [details]
Patch

I remove the "virtual" keyword in FrameLoaderClientEfl.cpp.

[Antonio Gomes]

Comment on attachment 67510 [details]
Patch

[23:13]  <demarchi> see in  WebCore/loader/EmptyClients.h
[23:13]  <demarchi> there's the following method:
[23:13]  <demarchi> +    virtual bool canShowMIMETypeAsHTML(const String&) const { return false; }
[23:13]  <demarchi> without ifdefs
[23:13]  <demarchi> but in WebCore/loader/FrameLoaderClient.h, they added the definition using #if PLATFORM(MAC)
[23:14]  <tonikitoo> so it should just remove the whole method. is that it?
[23:15]  <demarchi> i think so ...[quote]

[Gyuyoung Kim]

The "#if PLATFORM(MAC)" macro was removed in WebCore/loader/FrameLoaderClient.h. Reviewer wanted to remove the macro.(Bug 45494 Comment #6). So, I think we need to keep the function.

[Lucas De Marchi]

(In reply to comment #3)
> The "#if PLATFORM(MAC)" macro was removed in WebCore/loader/FrameLoaderClient.h. Reviewer wanted to remove the macro.(Bug 45494 Comment #6). So, I think we need to keep the function.

Antonio, as I told, that patch from MAC was wrong ;-).

Closing this bug.

[Lucas De Marchi]

Comment on attachment 67510 [details]
Patch

Clearing flags.

[Lucas De Marchi]

Re-opening this bug since the #if PLATFORM(MAC) was not removed yet.

Enrica, since the implementation of this method is just a NotImplemented() in EFL, do you think it's better to just remove it or you are going to remove the #if?

[Gyuyoung Kim]

Leandro already fix this bug. So, I close this bug.