Threaded mode should for in WebKit2 MiniBrowser
Created attachment 67509 [details] Patch
Attachment 67509 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/Launcher/qt/ThreadLauncherQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/Launcher/qt/ThreadLauncherQt.cpp:34: Alphabetical sorting problem. [build/include_order] [4] WebKit2/UIProcess/Launcher/win/ThreadLauncherWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/Launcher/ThreadLauncher.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 4 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 67509 [details] did not build on qt: Build output: http://queues.webkit.org/results/4021003
Created attachment 67511 [details] Updated to not break qt.
Created attachment 67512 [details] Update to not break windows.
Attachment 67512 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/Launcher/qt/ThreadLauncherQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/Launcher/qt/ThreadLauncherQt.cpp:34: Alphabetical sorting problem. [build/include_order] [4] WebKit2/UIProcess/Launcher/win/ThreadLauncherWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/Launcher/ThreadLauncher.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 4 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 67512 [details] Update to not break windows. r=me
Landed in r67433.