RESOLVED FIXED 45727
Threaded mode should work in WebKit2 MiniBrowser 
https://bugs.webkit.org/show_bug.cgi?id=45727
Summary Threaded mode should work in WebKit2 MiniBrowser
Sam Weinig
Reported 2010-09-13 19:17:37 PDT
Threaded mode should for in WebKit2 MiniBrowser
Attachments
Patch (34.05 KB, patch)
2010-09-13 19:19 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Updated to not break qt. (34.05 KB, patch)
2010-09-13 19:29 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Update to not break windows. (34.05 KB, patch)
2010-09-13 19:29 PDT, Sam Weinig 		jhoneycutt: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-09-13 19:19:46 PDT
Created attachment 67509 [details] Patch
WebKit Review Bot
Comment 2 2010-09-13 19:21:50 PDT
Attachment 67509 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/Launcher/qt/ThreadLauncherQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/Launcher/qt/ThreadLauncherQt.cpp:34: Alphabetical sorting problem. [build/include_order] [4] WebKit2/UIProcess/Launcher/win/ThreadLauncherWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/Launcher/ThreadLauncher.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 4 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2010-09-13 19:27:04 PDT
Attachment 67509 [details] did not build on qt: Build output: http://queues.webkit.org/results/4021003
Sam Weinig
Comment 4 2010-09-13 19:29:00 PDT
Created attachment 67511 [details] Updated to not break qt.
Sam Weinig
Comment 5 2010-09-13 19:29:43 PDT
Created attachment 67512 [details] Update to not break windows.
WebKit Review Bot
Comment 6 2010-09-13 19:31:27 PDT
Attachment 67512 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/Launcher/qt/ThreadLauncherQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/Launcher/qt/ThreadLauncherQt.cpp:34: Alphabetical sorting problem. [build/include_order] [4] WebKit2/UIProcess/Launcher/win/ThreadLauncherWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/Launcher/ThreadLauncher.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 4 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jon Honeycutt
Comment 7 2010-09-13 19:47:35 PDT
Comment on attachment 67512 [details] Update to not break windows. r=me
Sam Weinig
Comment 8 2010-09-13 19:49:03 PDT
Landed in r67433.
Note You need to log in before you can comment on or make changes to this bug.