Bug 45725 - commit-queue should log when it's retrying due to checkout out of date error
Summary: commit-queue should log when it's retrying due to checkout out of date error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-13 18:29 PDT by Eric Seidel (no email)
Modified: 2010-09-13 18:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.76 KB, patch)
2010-09-13 18:31 PDT, Eric Seidel (no email) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-09-13 18:29:26 PDT 
commit-queue should log when it's retrying due to checkout out of date error
Comment 1 Eric Seidel (no email) 2010-09-13 18:31:12 PDT 
Created attachment 67503 [details]
Patch
Comment 2 Adam Barth 2010-09-13 18:36:19 PDT 
Comment on attachment 67503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67503&action=prettypatch

> WebKitTools/Scripts/webkitpy/layout_tests/port/base_unittest.py:69
> -        return base.Port._open_configuration_file(self)
> +        raise IOError
This could be in a separate patch...
Comment 3 Eric Seidel (no email) 2010-09-13 18:39:00 PDT 
Committed r67429: <http://trac.webkit.org/changeset/67429>
Comment 4 Dirk Pranke 2010-09-13 18:39:43 PDT 
change to base_unittest.py looks good to me. Good catch; I thought I had that case covered but I was wrong.

Changes to the other python files look pretty good but I'm not an expert on that code.