Bug 45724 - Add custom binding code for DirectoryEntry to allow JSON parameters for Flags
Summary: Add custom binding code for DirectoryEntry to allow JSON parameters for Flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 42903
  Show dependency tree / graph
 
Reported: 2010-09-13 18:18 PDT by Kinuko Yasuda
Modified: 2010-09-30 13:39 PDT (History)
7 users (show)

See Also:

Attachments
Patch (22.67 KB, patch)
2010-09-13 18:20 PDT, Kinuko Yasuda 		dumi: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2010-09-13 18:18:12 PDT 
Add custom binding code for DirectoryEntry to allow JSON parameters for Flags.

DirectoryEntry.getFile() and getDirectory() need to be able to take Flags parameters in JSON format as in the example code:

http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#examples-1
4.2 Flags interface, 4.2.2 Examples:
> lockFile = dataDir.getFile("lockfile.txt", {create: true, exclusive: true});

Until we add some generic code in the generator (bug 45237) we need a short-term solution to make it work.
Comment 1 Kinuko Yasuda 2010-09-13 18:20:50 PDT 
Created attachment 67501 [details]
Patch
Comment 2 Dumitru Daniliuc 2010-09-14 14:59:04 PDT 
Comment on attachment 67501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67501&action=prettypatch

r=me, sorry it took so long to take a look at this patch.
Comment 3 Kinuko Yasuda 2010-09-14 23:41:59 PDT 
Committed r67538: <http://trac.webkit.org/changeset/67538>
Comment 4 WebKit Review Bot 2010-09-15 00:09:59 PDT 
http://trac.webkit.org/changeset/67538 might have broken GTK Linux 32-bit Release