Bug 45706 - SharedGraphicsContext3D's texture cache holds on to images after free
Summary: SharedGraphicsContext3D's texture cache holds on to images after free
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-13 13:49 PDT by James Robinson
Modified: 2010-09-13 14:39 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.08 KB, patch)
2010-09-13 14:00 PDT, James Robinson 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2010-09-13 13:49:53 PDT 
SharedGraphicsContext3D's texture cache holds on to images after free
Comment 1 James Robinson 2010-09-13 14:00:22 PDT 
Created attachment 67467 [details]
Patch
Comment 2 Kenneth Russell 2010-09-13 14:29:07 PDT 
Comment on attachment 67467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67467&action=prettypatch

Looks fine overall. Couple of minor comments.

> WebCore/ChangeLog:9
> +        Whenever the backing native image is deleted it needs to let the SharedGraphicsContext3D knows
knows -> know

> WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:196
> +         it != allContexts()->end(); ++it) {
This loop iteration should not be split across lines. No braces surrounding it.
Comment 3 James Robinson 2010-09-13 14:36:44 PDT 
Thanks for the review!  I'll fix the nits and land by hand.
Comment 4 James Robinson 2010-09-13 14:39:43 PDT 
Committed r67412: <http://trac.webkit.org/changeset/67412>