WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
45705
[BREWMP] Always set LeftButton in PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=45705
Summary
[BREWMP] Always set LeftButton in PlatformMouseEvent
Kwang Yul Seo
Reported
2010-09-13 13:35:43 PDT
AEE_POINTER_GET_MOUSE_MODIFIERS always returns 0, so it is impossible to know which button is pressed or released. The current code erroneously sets NoButton. Set LeftButton unconditionally because Brew MP usually runs on touch device.
Attachments
Patch
(1.96 KB, patch)
2010-09-13 13:37 PDT
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1
2010-09-13 13:37:28 PDT
Created
attachment 67466
[details]
Patch
Kent Tamura
Comment 2
2010-09-13 22:39:19 PDT
Comment on
attachment 67466
[details]
Patch Looks ok.
WebKit Commit Bot
Comment 3
2010-09-14 09:20:09 PDT
Comment on
attachment 67466
[details]
Patch Clearing flags on attachment: 67466 Committed
r67473
: <
http://trac.webkit.org/changeset/67473
>
WebKit Commit Bot
Comment 4
2010-09-14 09:20:13 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug