Bug 45704 - Potential leak in JSSVGDynamicPODTypeWrapper
Summary: Potential leak in JSSVGDynamicPODTypeWrapper
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-13 13:35 PDT by Alexey Proskuryakov
Modified: 2024-01-28 16:25 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-09-13 13:35:09 PDT 
JSSVGDynamicPODTypeWrapper inherits from RefCounted (via JSSVGPODTypeWrapper), but RefCounted will not call its virtual destructor. So, data members of JSSVGDynamicPODTypeWrapper will not be destructed in the normal course of RefCounted lifetime.

I think the original issue is that JSSVGPODTypeWrapper should not have inherited from RefCounted, and then someone fell into the trap of actually doing meaningful work in the destructor.
Comment 1 Ahmad Saleem 2024-01-28 05:06:47 PST 
@Alexey - Is this applicable anymore? I couldn't find any references to this in our code base?

It seems this commit removed it - https://github.com/WebKit/WebKit/commit/4d739154052f4dda48b5cd06e09c0d896955c568