Bug 45701 - [BREWMP] Set m_size in SharedBuffer::createWithContentsOfFile();
Summary: [BREWMP] Set m_size in SharedBuffer::createWithContentsOfFile();
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency treegraph
 
Reported: 2010-09-13 13:06 PDT by Hyung Song
Modified: 2010-09-14 09:14 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2010-09-13 13:14 PDT, Hyung Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hyung Song 2010-09-13 13:06:49 PDT
SharedBuffer::createWithContentsOfFile() reads file content and saves to result.m_buffer directly, leaving result.m_size unchanged.
Comment 1 Hyung Song 2010-09-13 13:14:33 PDT
Created attachment 67462 [details]
Patch
Comment 2 WebKit Commit Bot 2010-09-14 07:43:06 PDT
Comment on attachment 67462 [details]
Patch

Clearing flags on attachment: 67462

Committed r67468: <http://trac.webkit.org/changeset/67468>
Comment 3 WebKit Commit Bot 2010-09-14 07:43:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-09-14 09:14:21 PDT
http://trac.webkit.org/changeset/67468 might have broken GTK Linux 32-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/67465
http://trac.webkit.org/changeset/67466
http://trac.webkit.org/changeset/67467
http://trac.webkit.org/changeset/67468