Bug 45699 – ResourceResponseBase::setMimeType wants mimetype and not content type

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Fridrich Strba]

If we pass to the ResourceResponseBase::setMimeType a content type instead of mimetype, we might be lucky on platform, where the two are the same, but it breaks loading of local files on windows. The attached patch fixes this problem

[Fridrich Strba]

Created attachment 67460 [details]
Patch

[Martin Robinson]

Comment on attachment 67460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67460&action=prettypatch

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:869
> +    response.setMimeType(g_content_type_get_mime_type(g_file_info_get_content_type(info)));
It isn't well documented, but this is a memory leak, because g_content_type_get_mime_type returns a newly-allocated string.

[Martin Robinson]

I don't think this is an issue any longer. The code looks like this now:

        const gchar* contentType = soup_request_get_content_type(d->m_soupRequest.get());
        d->m_response.setMimeType(extractMIMETypeFromMediaType(contentType));

The Soup content type is always the mime type. Feel free to re-open if I'm wrong about this.