Bug 45698 - [chromium] Remove unused ICU headers
Summary: [chromium] Remove unused ICU headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-13 12:51 PDT by Kwang Yul Seo
Modified: 2010-09-14 12:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2010-09-13 12:52 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Patch (1022 bytes, patch)
2010-09-13 18:06 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-09-13 12:51:00 PDT 
ICU headers included in FontLinux.cpp and FontCacheLinux.cpp are not used.Remove them.
Comment 1 Kwang Yul Seo 2010-09-13 12:52:43 PDT 
Created attachment 67458 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-13 16:05:32 PDT 
Attachment 67458 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3933436
Comment 3 Kwang Yul Seo 2010-09-13 18:06:42 PDT 
Created attachment 67496 [details]
Patch

<unicode/utf16.h> is not used.
Comment 4 Kwang Yul Seo 2010-09-13 18:07:07 PDT 
Reopen the bug.
Comment 5 Andreas Kling 2010-09-14 06:44:55 PDT 
Comment on attachment 67496 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2010-09-14 12:44:38 PDT 
Comment on attachment 67496 [details]
Patch

Clearing flags on attachment: 67496

Committed r67485: <http://trac.webkit.org/changeset/67485>
Comment 7 WebKit Commit Bot 2010-09-14 12:44:43 PDT 
All reviewed patches have been landed.  Closing bug.