Bug 45695 – Preparation for eliminating deprecatedParseURL

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Darin Adler]

Preparation for eliminating deprecatedParseURL

[Darin Adler]

Created attachment 67451 [details]
Patch

[Early Warning System Bot]

Attachment 67451 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3989080

[Darin Adler]

I’ll have to add an include to make things compile on Qt.

    HTMLParserIdioms.cpp:82: error: 'isfinite' was not declared in this scope

<math.h> or <wtf/MathExtras.h>.

[WebKit Review Bot]

Attachment 67451 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3938448

[Darin Adler]

Chromium build issue is the same as the Qt one.

[Adam Barth]

Comment on attachment 67451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67451&action=prettypatch

> JavaScriptCore/wtf/text/WTFString.h:56
> +struct StringHash;
Not sure how this is related.

> WebCore/html/parser/HTMLParserIdioms.h:38
> +// Strip leading and trailing whitespace as defined by the HTML specification. 
> +String stripLeadingAndTrailingHTMLSpaces(const String&);
This function doesn't seem to be used yet, but presumably that's the next step?

[WebKit Review Bot]

Attachment 67451 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/3964437

[Darin Adler]

Comment on attachment 67451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67451&action=prettypatch

Thanks for the review.

> JavaScriptCore/wtf/text/WTFString.h:56
> +struct StringHash;
Just moved this up to the top of the file where the other forward class declarations are instead of down at the bottom of the file where it’s used.

> WebCore/html/parser/HTMLParserIdioms.h:38
> +String stripLeadingAndTrailingHTMLSpaces(const String&);
Yes. I considered calling it at one particular call site, but on balance decided it was OK to land without that.

[Darin Adler]

Committed r67423: <http://trac.webkit.org/changeset/67423>