Bug 45682 - [WINCE] Add FrameLoaderClientWinCE
: [WINCE] Add FrameLoaderClientWinCE
Status: RESOLVED FIXED
: WebKit
WebKit Misc.
: 528+ (Nightly build)
: Other Other
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-09-13 10:11 PST by
Modified: 2010-09-20 11:12 PST (History)


Attachments
Patch (33.40 KB, patch)
2010-09-13 10:27 PST, Patrick R. Gansterer
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-09-13 10:11:01 PST
see patch
------- Comment #1 From 2010-09-13 10:27:43 PST -------
Created an attachment (id=67426) [details]
Patch
------- Comment #2 From 2010-09-20 08:35:34 PST -------
(From update of attachment 67426 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=67426&action=review

> WebKit/wince/ChangeLog:9
> +        * WebCoreSupport/FrameLoaderClientWinCE.cpp: Added.
> +        (WebKit::FrameLoaderClient::FrameLoaderClient):

WebKit's standard style is for the file name to match the class name (ignoring namespaces). So the file name should be FrameLoaderClient.cpp. I see that the other files in this directory use the pattern you've used here, though.

> WebKit/wince/ChangeLog:28
> +        (WebKit::FrameLoaderClient::~FrameLoaderClient):
> +        (WebKit::FrameLoaderClient::userAgent):
> +        (WebKit::FrameLoaderClient::createDocumentLoader):
> +        (WebKit::FrameLoaderClient::committedLoad):
> +        (WebKit::FrameLoaderClient::shouldUseCredentialStorage):
> +        (WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
> +        (WebKit::FrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
> +        (WebKit::FrameLoaderClient::dispatchWillSendRequest):
> +        (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
> +        (WebKit::FrameLoaderClient::postProgressStartedNotification):
> +        (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification):
> +        (WebKit::FrameLoaderClient::postProgressFinishedNotification):
> +        (WebKit::FrameLoaderClient::frameLoaderDestroyed):
> +        (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
> +        (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
> +        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
> +        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
> +        (WebKit::FrameLoaderClient::dispatchWillSubmitForm):
> +        (WebKit::FrameLoaderClient::createPlugin):

All these uncommented-on function names don't really make the ChangeLog any more helpful. You could group them into categories (implemented vs. unimplemented and needs implementation vs. unimplemented and doesn't need implementation). Or you could omit all but the functions you've implemented (and maybe comment on those). Or you could omit all of them.

> WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp:59
> +WTF::PassRefPtr<WebCore::DocumentLoader> FrameLoaderClient::createDocumentLoader(const WebCore::ResourceRequest& request, const SubstituteData& substituteData)

No need for WTF:: here.
------- Comment #3 From 2010-09-20 11:12:30 PST -------
(From update of attachment 67426 [details])
Clearing flags on attachment: 67426

Manually committed r67863: <http://trac.webkit.org/changeset/67863>
------- Comment #4 From 2010-09-20 11:12:58 PST -------
All reviewed patches have been landed.  Closing bug.