Bug 45682 - [WINCE] Add FrameLoaderClientWinCE
: [WINCE] Add FrameLoaderClientWinCE
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Misc.
: 528+ (Nightly build)
: Other Other
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-13 10:11 PDT by Patrick R. Gansterer
Modified: 2010-09-20 11:12 PDT (History)
1 user (show)

See Also:


Attachments
Patch (33.40 KB, patch)
2010-09-13 10:27 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-09-13 10:11:01 PDT
see patch
Comment 1 Patrick R. Gansterer 2010-09-13 10:27:43 PDT
Created attachment 67426 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-09-20 08:35:34 PDT
Comment on attachment 67426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67426&action=review

> WebKit/wince/ChangeLog:9
> +        * WebCoreSupport/FrameLoaderClientWinCE.cpp: Added.
> +        (WebKit::FrameLoaderClient::FrameLoaderClient):

WebKit's standard style is for the file name to match the class name (ignoring namespaces). So the file name should be FrameLoaderClient.cpp. I see that the other files in this directory use the pattern you've used here, though.

> WebKit/wince/ChangeLog:28
> +        (WebKit::FrameLoaderClient::~FrameLoaderClient):
> +        (WebKit::FrameLoaderClient::userAgent):
> +        (WebKit::FrameLoaderClient::createDocumentLoader):
> +        (WebKit::FrameLoaderClient::committedLoad):
> +        (WebKit::FrameLoaderClient::shouldUseCredentialStorage):
> +        (WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
> +        (WebKit::FrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
> +        (WebKit::FrameLoaderClient::dispatchWillSendRequest):
> +        (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
> +        (WebKit::FrameLoaderClient::postProgressStartedNotification):
> +        (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification):
> +        (WebKit::FrameLoaderClient::postProgressFinishedNotification):
> +        (WebKit::FrameLoaderClient::frameLoaderDestroyed):
> +        (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
> +        (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
> +        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
> +        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
> +        (WebKit::FrameLoaderClient::dispatchWillSubmitForm):
> +        (WebKit::FrameLoaderClient::createPlugin):

All these uncommented-on function names don't really make the ChangeLog any more helpful. You could group them into categories (implemented vs. unimplemented and needs implementation vs. unimplemented and doesn't need implementation). Or you could omit all but the functions you've implemented (and maybe comment on those). Or you could omit all of them.

> WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp:59
> +WTF::PassRefPtr<WebCore::DocumentLoader> FrameLoaderClient::createDocumentLoader(const WebCore::ResourceRequest& request, const SubstituteData& substituteData)

No need for WTF:: here.
Comment 3 Patrick R. Gansterer 2010-09-20 11:12:30 PDT
Comment on attachment 67426 [details]
Patch

Clearing flags on attachment: 67426

Manually committed r67863: <http://trac.webkit.org/changeset/67863>
Comment 4 Patrick R. Gansterer 2010-09-20 11:12:58 PDT
All reviewed patches have been landed.  Closing bug.