Bug 45682 – [WINCE] Add FrameLoaderClientWinCE

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 67426 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 67426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67426&action=review

> WebKit/wince/ChangeLog:9
> +        * WebCoreSupport/FrameLoaderClientWinCE.cpp: Added.
> +        (WebKit::FrameLoaderClient::FrameLoaderClient):

WebKit's standard style is for the file name to match the class name (ignoring namespaces). So the file name should be FrameLoaderClient.cpp. I see that the other files in this directory use the pattern you've used here, though.

> WebKit/wince/ChangeLog:28
> +        (WebKit::FrameLoaderClient::~FrameLoaderClient):
> +        (WebKit::FrameLoaderClient::userAgent):
> +        (WebKit::FrameLoaderClient::createDocumentLoader):
> +        (WebKit::FrameLoaderClient::committedLoad):
> +        (WebKit::FrameLoaderClient::shouldUseCredentialStorage):
> +        (WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
> +        (WebKit::FrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
> +        (WebKit::FrameLoaderClient::dispatchWillSendRequest):
> +        (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
> +        (WebKit::FrameLoaderClient::postProgressStartedNotification):
> +        (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification):
> +        (WebKit::FrameLoaderClient::postProgressFinishedNotification):
> +        (WebKit::FrameLoaderClient::frameLoaderDestroyed):
> +        (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
> +        (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
> +        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
> +        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
> +        (WebKit::FrameLoaderClient::dispatchWillSubmitForm):
> +        (WebKit::FrameLoaderClient::createPlugin):

All these uncommented-on function names don't really make the ChangeLog any more helpful. You could group them into categories (implemented vs. unimplemented and needs implementation vs. unimplemented and doesn't need implementation). Or you could omit all but the functions you've implemented (and maybe comment on those). Or you could omit all of them.

> WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp:59
> +WTF::PassRefPtr<WebCore::DocumentLoader> FrameLoaderClient::createDocumentLoader(const WebCore::ResourceRequest& request, const SubstituteData& substituteData)

No need for WTF:: here.

[Patrick R. Gansterer]

Comment on attachment 67426 [details]
Patch

Clearing flags on attachment: 67426

Manually committed r67863: <http://trac.webkit.org/changeset/67863>

[Patrick R. Gansterer]

All reviewed patches have been landed.  Closing bug.