Bug 45680 – [WINCE] Add FrameNetworkingContextWinCE::blockedError

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 67420 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 67420 [details]
Patch

I'm confused.  Is this to fix a compile error?  What is this doing?  Should this be calling notImplemented()? since this seems like a dummy implementation.  Please update the ChangeLog to explain.

[Patrick R. Gansterer]

Created attachment 67657 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 67657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67657&action=prettypatch

> WebKit/wince/WebCoreSupport/FrameNetworkingContextWinCE.cpp:55
> +WebCore::ResourceError FrameNetworkingContextWinCE::blockedError(const WebCore::ResourceRequest&) const
> +{
> +    notImplemented();
> +    return WebCore::ResourceError();
> +}

There's no need for any of the "WebCore::"s here, since you have "using namespace WebCore;" near the top of the file.

[Patrick R. Gansterer]

Comment on attachment 67657 [details]
Patch

(In reply to comment #4)
> There's no need for any of the "WebCore::"s here, since you have "using namespace WebCore;" near the top of the file.
You're wrong. ;-) E.g: http://msdn.microsoft.com/en-us/library/ms919861.aspx

[Patrick R. Gansterer]

(In reply to comment #4)
> (From update of attachment 67657 [details])
> > WebKit/wince/WebCoreSupport/FrameNetworkingContextWinCE.cpp:55
> > +WebCore::ResourceError FrameNetworkingContextWinCE::blockedError(const WebCore::ResourceRequest&) const
> > +{
> > +    notImplemented();
> > +    return WebCore::ResourceError();
> > +}
> 
> There's no need for any of the "WebCore::"s here, since you have "using namespace WebCore;" near the top of the file.
I can remove it at WebCore::ResourceError, but it's strange to have it only on some places...

[Adam Roben (:aroben)]

(In reply to comment #5)
> (From update of attachment 67657 [details])
> (In reply to comment #4)
> > There's no need for any of the "WebCore::"s here, since you have "using namespace WebCore;" near the top of the file.
> You're wrong. ;-) E.g: http://msdn.microsoft.com/en-us/library/ms919861.aspx

Oh my! I've never heard of that function.

> I can remove it at WebCore::ResourceError, but it's strange to have it only on some places...

OK.

[WebKit Commit Bot]

Comment on attachment 67657 [details]
Patch

Clearing flags on attachment: 67657

Committed r67620: <http://trac.webkit.org/changeset/67620>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.