Bug 45671 - Web Inspector: provide support for opening external navigation for links within certain elements
Summary: Web Inspector: provide support for opening external navigation for links with...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-13 07:33 PDT by Andrey Kosyakov
Modified: 2010-09-14 08:36 PDT (History)
9 users (show)

See Also:

Attachments
patch (3.60 KB, patch)
2010-09-13 07:42 PDT, Andrey Kosyakov 		pfeldman: review-
Details | Formatted Diff | Diff
patch (2.42 KB, patch)
2010-09-13 08:20 PDT, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2010-09-13 07:33:51 PDT 
Currently, Web Inspector always opens resource panel when a link is clicked. Some extensions may need to override this behavior for certain links (e.g. documentation etc).
The proposed patch enables default handling for links that have target="_blank" and are found within containers that have "allow-external-navigation" style.
Comment 1 Andrey Kosyakov 2010-09-13 07:42:32 PDT 
Created attachment 67407 [details]
patch
Comment 2 Pavel Feldman 2010-09-13 08:03:38 PDT 
Comment on attachment 67407 [details]
patch

I'd much rather leave a single if (anchor.target === "_blank") check and would manually create <a hrefs in extensions subsystem. Rationale: WebInspector.linkify is too involved with resources panel.
Comment 3 Andrey Kosyakov 2010-09-13 08:20:20 PDT 
Created attachment 67412 [details]
patch

- removed "allow-external-navigation", let all links with target="_blank" use default handling
- removed adding target="_blank" in WebInspector.linkifyURL()
Comment 4 Andrey Kosyakov 2010-09-14 08:36:23 PDT 
Manually committed as r67454: http://trac.webkit.org/changeset/67454